Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EnsureStorageNamespace close reader #8346

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Nov 4, 2024

Closes #8326

Change Description

Background

io.Reader remains open after getting object

@N-o-Z N-o-Z added bug Something isn't working include-changelog PR description should be included in next release changelog labels Nov 4, 2024
@N-o-Z N-o-Z requested a review from a team November 4, 2024 21:18
@N-o-Z N-o-Z self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

github-actions bot commented Nov 4, 2024

E2E Test Results - Quickstart

11 passed

Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW

@N-o-Z N-o-Z merged commit bf98183 into master Nov 5, 2024
42 checks passed
@N-o-Z N-o-Z deleted the fix/close-io-reader-on-ensure-storage-namespace-8326 branch November 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ensureStorageNamespace does not close io reader
3 participants